Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added -B/-E to trimfq for keeping first/last INT bp and also -s for shortest read #91

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

ndaniel
Copy link

@ndaniel ndaniel commented Mar 6, 2017

This is basically a resurrected issue #38 which was brought up to date to the latest release of seqtk such that they do not interfere with the original command line options of seqtk anymore.

More precisely this adds for trimfq the following:

-s INT      trimming by -b/-e/-B/-E shall not produce reads shorter then INT bp
-B INT      keep first INT bp from left (non-zero to disable -q/-e/-E)
-E INT      keep last INT bp from right (non-zero to disable -q/-b/-B)

This allows a more precise control of how trimming is done. This kind of trimming is used heavily in FusionCatcher (by using a forked seqtk instead of the original seqtk). Here #38 was mentioned that this kind of trimming is rare but actually in ractice is used a lot. Regarding popularity of such trimming, one has that, for example:

ndaniel and others added 30 commits September 19, 2014 22:39
added -B/-E to trimfq for keeping first/last INT bp"
fixing bugs and also "shortcircuting" the case when param == 0
fixing bugs
fixing description
Updated with -B/-E for trimfq examples
fixed typo "rigth" to "right"
updated version string to 1.0-r68a-dirty
Added the possibility to use simultaneously in trimfq:
a) -e with -E, and 
b) -b with -B.
Added examples for use simultaneously use with trimfq of:
a) -e with -E, and 
b) -b with -B.
setting the minimum length
the minimum reads after the trimming is 1 instead of zero (no reads with length 0 are created)
fixes bugs and descriptions of "trimfq -l"
Adding example for "trimfq -l" usage with other trimming options.
trying to fix locally the bug where reads with no sequence are converted to FASTA format in TRIMFQ and also setting be default "trimfq -l" to 1 instead of 30.
fixing bug in trimfq
fixed bugs regarding trimfq
updated to the version string to: 1.0-r68e-dirty
@yhoogstrate
Copy link

Any news here @lh3 @ndaniel ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants