improve text edit mode

lhns · Feb 28, 2023 · 76f1f7b · 76f1f7b
1 parent 5e5adda
commit 76f1f7b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/JsonEditorListComponent.tsx b/src/JsonEditorListComponent.tsx
@@ -56,10 +56,10 @@ class JsonEditorListComponent extends React.Component<{
             <div className="flex-fill list-json-editor-panel">
                 <ScrollPane>
                     <div className="p-2">
-                        {selectedIndex != null && (data?.entries ?? [])[selectedIndex] ?
+                        {selectedIndex != null && data?.entries?.[selectedIndex] != null ?
                             <JsonEditorComponent
                                 schema={{$schema: schema?.$schema, ...(schema?.properties?.entries?.items ?? {})}}
-                                data={(data?.entries ?? [])[selectedIndex]}
+                                data={data?.entries?.[selectedIndex]}
                                 onChange={entryData => onChange({
                                     ...data,
                                     entries: (data?.entries ?? []).map((entry: any, i: number) => selectedIndex == i ? entryData : entry)

diff --git a/src/JsonEditorTextComponent.tsx b/src/JsonEditorTextComponent.tsx
@@ -19,13 +19,13 @@ class JsonEditorTextComponent extends React.Component<{
     componentDidUpdate(prevProps: any) {
         const {data} = this.props
 
-        if (data !== prevProps.data) {
+        if (JSON.stringify(data) !== JSON.stringify(prevProps.data)) {
             this.setState(state => ({...state, value: JSON.stringify(data, null, 2)}))
         }
     }
 
     render() {
-        const {schema, data, onChange} = this.props
+        const {data, onChange} = this.props
         const {value} = this.state ?? {}
 
         return data != null ? <Editor