Refactor and document the Cut hierarchy (Cut -> MonoCut, CutUtilsBase -> Cut) #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzelasko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am going with the name
MonoCutbecause it always represents a single channel. The inheritance fromCut(which now is a real base class) is cleaner and shouldn't be confusing like before (especially after I write the updated docs). There is no need for the hacky typing hintAnyCutanymore.In a future PR, I will need to explore if MixedCut is sufficient to represent multi-channel data for training, if not maybe we'll add a MultiCut.
I think that snowfall and existing training data should work fine with these changes, but I will test it anyway before I merge this PR.