Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bucketing method with equal cumulative bucket duration #365

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

pzelasko
Copy link
Collaborator

@pzelasko pzelasko commented Aug 10, 2021

Hopefully resolves the issue #364

@danpovey @csukuangfj please check this out and LMK if it helps with the sawtoothed loss

To use it, add the argument:

sampler = BucketingSampler(
   ...,
   bucket_method='equal_duration',
)

@pzelasko pzelasko added this to the v0.8 milestone Aug 10, 2021
@pzelasko
Copy link
Collaborator Author

I also double-checked that shuffling works as intended in the BucketingSampler.

@pzelasko pzelasko merged commit 5dfe0f4 into master Aug 10, 2021
@csukuangfj
Copy link
Contributor

Thanks! Will try it and post the result here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants