Add Fisher English #374
Merged
Add Fisher English #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks great! Could you also update the table that lists all available corpora in LMK if it's otherwise ready to merge. |
|
Added Fisher corpus to |
pzelasko
reviewed
Aug 15, 2021
lhotse/recipes/fisher_english.py
Outdated
| output_dir = Path(output_dir) | ||
| output_dir.mkdir(parents=True, exist_ok=True) | ||
| recordings.to_json(output_dir / 'recordings.json') | ||
| supervisions.to_json(output_dir / 'supervisions.json') |
There was a problem hiding this comment.
Since Fisher is large at ~2000h, I suggest writing both of those as jsonl instead, like this:
Suggested change
| supervisions.to_json(output_dir / 'supervisions.json') | |
| supervisions.to_file(output_dir / 'supervisions.jsonl.gz') |
It will enable others to use the lazy manifest mechanism if needed.
There was a problem hiding this comment.
ok, will change now.
|
Thanks, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fisher English recipe.