Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloading GigaSpeech with PySpeechColab #381

Merged
merged 8 commits into from
Aug 23, 2021
Merged

Downloading GigaSpeech with PySpeechColab #381

merged 8 commits into from
Aug 23, 2021

Conversation

jimbozhang
Copy link
Contributor

@pzelasko
Copy link
Collaborator

Cool, thanks! Did you test that the downloaded data is compatible with prepare_gigaspeech (at least on a small subset)?

@jimbozhang jimbozhang marked this pull request as draft August 23, 2021 00:51
@jimbozhang jimbozhang marked this pull request as ready for review August 23, 2021 01:02
@jimbozhang
Copy link
Contributor Author

I just tested it. Now prepare_gigaspeech has been ready.

@jimbozhang jimbozhang requested a review from pzelasko August 23, 2021 09:47
@pzelasko
Copy link
Collaborator

Thanks! Can you please fix the CI? There is an import error of a variable GIGASPEECH_PARTS somewhere

@jimbozhang jimbozhang marked this pull request as draft August 23, 2021 13:28
@jimbozhang jimbozhang marked this pull request as ready for review August 23, 2021 13:33
@pzelasko
Copy link
Collaborator

Thanks! LGTM

@pzelasko pzelasko merged commit 26045e9 into lhotse-speech:master Aug 23, 2021
@pzelasko pzelasko added this to the v0.8 milestone Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzelasko pzelasko Awaiting requested review from pzelasko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@jimbozhang @pzelasko