Feature/volume perturbation #382
Conversation
|
|
||
| def __init__( | ||
| self, | ||
| factors: Union[float, List[float]], |
There was a problem hiding this comment.
| factors: Union[float, List[float]], | |
| factors: Union[float, Sequence[float]], |
This allows tuples without type checker conflicts
|
|
||
|
|
||
| def test_deserialize_transform(audio): | ||
| speed = AudioTransform.from_dict({'name': 'Speed', 'kwargs': {'factor': 1.1}}) | ||
| perturbed = speed(audio, SAMPLING_RATE) | ||
| assert perturbed.shape == (1, 14545) |
There was a problem hiding this comment.
These changes would ideally be introduced in a copy of this unit test (my principle is one logical assertion == one unit test, to avoid tests that check two or more independent functionalities because they are confusing to readers and harder to debug)
test/augmentation/test_torchaudio.py
Outdated
| speed = AudioTransform.from_dict(data) | ||
| perturbed = speed(audio, SAMPLING_RATE) | ||
| assert perturbed.shape == (1, 14545) | ||
| vol_orig = Vol(factor=0.5) |
|
I split tests and replaced |
|
Oh yeah that's a good catch. Thanks a lot! |
Add volume perturbation