Skip to content

Commit

Permalink
[stable/external-dns] Added custom volume support (helm#21285)
Browse files Browse the repository at this point in the history
Signed-off-by: Dan Sexton <dan.b.sexton@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
  • Loading branch information
dsexton authored and li-adrienloiseau committed Jul 29, 2020
1 parent 206310f commit 2184775
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 2 deletions.
2 changes: 1 addition & 1 deletion stable/external-dns/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: external-dns
version: 2.19.2
version: 2.20.0
appVersion: 0.6.0
description: ExternalDNS is a Kubernetes addon that configures public DNS servers with information about exposed Kubernetes services to make them discoverable.
keywords:
Expand Down
2 changes: 2 additions & 0 deletions stable/external-dns/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@ The following table lists the configurable parameters of the external-dns chart
| `resources` | CPU/Memory resource requests/limits. | `{}` |
| `livenessProbe` | Deployment Liveness Probe | See `values.yaml` |
| `readinessProbe` | Deployment Readiness Probe | See `values.yaml` |
| `extraVolumes` | A list of volumes to be added to the pod | `[]` |
| `extraVolumeMounts` | A list of volume mounts to be added to the pod | `[]` |
| `metrics.enabled` | Enable prometheus to access external-dns metrics endpoint | `false` |
| `metrics.podAnnotations` | Annotations for enabling prometheus to access the metrics endpoint | |
| `metrics.serviceMonitor.enabled` | Create ServiceMonitor object | `false` |
Expand Down
8 changes: 8 additions & 0 deletions stable/external-dns/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,10 @@ spec:
mountPath: /transip
readOnly: true
{{- end }}
# Extra volume mount(s)
{{- if .Values.extraVolumeMounts }}
{{ toYaml .Values.extraVolumeMounts | indent 8 }}
{{- end }}
volumes:
# AWS volume(s)
{{- if and (eq .Values.provider "aws") (or (and .Values.aws.credentials.secretKey .Values.aws.credentials.accessKey) .Values.aws.credentials.secretName) }}
Expand Down Expand Up @@ -482,3 +486,7 @@ spec:
secret:
name: {{ template "external-dns.fullname" . }}
{{- end }}
# Extra volume(s)
{{- if .Values.extraVolumes }}
{{ toYaml .Values.extraVolumes | indent 6 }}
{{- end }}
8 changes: 7 additions & 1 deletion stable/external-dns/values-production.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ aws:
preferCNAME: ""
## Enable AWS evaluation of target health. Available values are: true, false
##
evaluateTargetHealth: ""
evaluateTargetHealth: ""

## Azure configuration to be set via arguments/env. variables
##
Expand Down Expand Up @@ -471,6 +471,12 @@ readinessProbe:
failureThreshold: 6
successThreshold: 1

## Configure extra volumes
extraVolumes: []

## Configure extra volumeMounts
extraVolumeMounts: []

## Prometheus Exporter / Metrics
##
metrics:
Expand Down
6 changes: 6 additions & 0 deletions stable/external-dns/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,12 @@ readinessProbe:
failureThreshold: 6
successThreshold: 1

## Configure extra volumes
extraVolumes: []

## Configure extra volumeMounts
extraVolumeMounts: []

## Prometheus Exporter / Metrics
##
metrics:
Expand Down

0 comments on commit 2184775

Please sign in to comment.