Fix event.off not removing callback #1021
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey there, I was using Events module, but I wasn't enabled to remove a callback passing it as an argument, the only way to remove it, was to remove all the events calling Events.off( object, eventName ), so after reviewing the Events module I found the issue, so base in this the correct way to check if two functions are equal is first to parse them as a string, and then compare if the results are equal. So I just modified one line of the module converting the callbacks to string in the if statement (line 65)
here is part of my code if it is needed to replicate the issue