Fix inconsistent Bodies.fromVertices behavior #1178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
Bodies.fromVertices
with an array ofvertexSets
in which some vertexSets are convex and some are concave, the convex vertices end up in wildly different places from the concave vertices.See the following example, where in vectorized text, the three convex parts (making up the “i” and the “o”) are out of place with the rest of the (concave) parts, even though they were correctly positioned in the input data:
This occurs because the Bodies.fromVertices implementation sets the
x
,y
of convex parts to the inputx
,y
(which is the same for every part) but it sets thex
,y
of concave parts to the center of mass of the part.This pull request makes the behavior consistent by ensuring every part has its position set to its center of mass, so that multiple vertexSets passed to
Matter.fromVertices
have their relative positions preserved.