Static libs seem to always link in references

[TheClassic]

When building through Visual Studio, I get no linking errors. With msfastbuild, I get error LNK4006 (symbol already defined). I noticed referenced projects were included in the bff under Librarian Options, which is not what I would expect in this case (normally expect to link the references into a dll or exe not a static lib). I was able to reproduce this problem in Visual Studio by enabling the Librarian option "Link Library Dependencies". I propose and plan on only including referenced libs if this option is set to true. (I'll probably have a pull request before anybody reads this, but if not, feedback on the plan would be appreciated)

[liamkf]

Your plan seems reasonable to me! I don't have too many projects I've built that use those project reference options so there's probably a few problems lurking in there. I would think checking if the LinkLibraryDependencies node is false before adding the dependent in EvaluateProjectReferences would be enough. I'm not quite sure what I'm expecting if we're referencing the output assembly but not linking the dependencies... if the project is available somewhere I'd be happy to have a look or add it to the things that get built.

Regardless, thanks for the report, and let me know if you get stuck!

[TheClassic]

Thanks, I have some ideas, I'll take a stab. Unfortunately, I can't share
what I'm using this for so I would have to contrive examples. Thanks for
making this available, having a blast.

On Tue, Nov 15, 2016, 11:31 PM Liam notifications@github.com wrote:

Your plan seems reasonable to me! I don't have too many projects I've
built that use those project reference options so there's probably a few
problems lurking in there. I would think checking if the
LinkLibraryDependencies node is false before adding the dependent in
EvaluateProjectReferences would be enough. I'm not quite sure what I'm
expecting if we're referencing the output assembly but not linking the
dependencies... if the project is available somewhere I'd be happy to have
a look or add it to the things that get built.

Regardless, thanks for the report, and let me know if you get stuck!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#17 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABi1de3wS6S8lXlKJ7by7qNvFcQ5NlQuks5q-octgaJpZM4KzRXa
.