This repository has been archived by the owner on Jul 11, 2024. It is now read-only.
Fix crash caused by combining unicode characters #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o printf style format specifiers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29
Basically, when an item in the array of strings contains a combining character at the start that hasn't combined with anything, it'll combine into the proceeding
Characteronce the string gets merged into the final output and this was throwing off the ranges that I'd been calculating.This then uncovered a whole bunch of other issues that led me to give up on my optimistic task of parsing
%@style variables and instead revert back to the{0}style pattern in the Unicode CLDR data.I then changed a bunch of logic to fix this (backed mostly by tests) however I'm not really finished here.. I want to rewrite all of this but need it working first to confirm its performance.