Compile snapshots using Swift 6 Language Mode #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Pull Request passed benchmark checks SummaryWed Jun 19 13:27:54 UTC 2024 New baseline 'pull_request' is WITHIN the 'main' baseline thresholds. Comparing results between 'main' and 'pull_request'XCStringsToolBenchmarksStringGenerator.generateSource(for:tableName:accessLevel:) metrics
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing in preparation for 0.5.1, I realised that I am missing tests to ensure that the generated source actually compiles in Swift 6 language mode.
When adding them, I found that
LocalizableStringResource.Localizablefails to compile whenpublicbecause it's not annotated asSendable. Therefore I also added this annotation.