Bring support to all OS versions #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamnichols
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #50, we extended support to iOS 15+ by using
String.init(localized:defaultValue:table:bundle:locale:), but it turned out that there was no advantage to using this initialiser over using the originalString.init(format:locale:arguments:)combined withBundle.localizedString(forKey:value:table:).I thought that there was originally because I thought that the newer init allowed you to override the language with the
localeargument, but it turned out that thelocaleis only used for formatting arguments (i.e decimals) and nothing else.As a result, I have switched the generated code to use
String.init(format:locale:arguments:), which means that it will work across all OS versions now 🚀The only version constrained code is the use of
LocalizedStringResource