Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix availability of LocalizedStringKey extension (iOS 14+) #88

Merged
merged 1 commit into from
May 28, 2024

Conversation

liamnichols
Copy link
Owner

@liamnichols liamnichols commented May 28, 2024

When using 0.4.0 with a project that targets iOS 13+, the generated code will fail to compile with the following error:

Screenshot 2024-05-28 at 20 35 05

This is because Text can't be embedded inside LocalizedStringKey on iOS 13, so we need to add the @availability annotations to mark it as WWDC 2020+

@liamnichols liamnichols self-assigned this May 28, 2024
@liamnichols liamnichols marked this pull request as ready for review May 28, 2024 19:26
@liamnichols liamnichols merged commit 865b0fc into main May 28, 2024
4 checks passed
@liamnichols liamnichols deleted the ln/localized-string-key-fix-availability branch May 28, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant