Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Swift 6 preparation #90

Closed

Conversation

Brett-Best
Copy link

  • Enabled upcoming/experimental swift feature flags
  • Fixed most of the new warnings

Remaining are:

XCStringsTool
/Sources/StringExtractor/StringParser.swift
/Sources/StringExtractor/StringParser.swift:62:16 Static property 'regex' is not concurrency-safe because it is not either conforming to 'Sendable' or isolated to a global actor; this is an error in Swift 6

PluginTests
/DerivedData/xcstrings-tool-dmlhbkyuqhmcebaijwuzkgpsrtoy/SourcePackages/plugins/xcstrings-tool.output/PluginTests/XCStringsToolPlugin/XCStringsTool/FeatureOne.swift
/DerivedData/xcstrings-tool-dmlhbkyuqhmcebaijwuzkgpsrtoy/SourcePackages/plugins/xcstrings-tool.output/PluginTests/XCStringsToolPlugin/XCStringsTool/FeatureOne.swift:224:170 Static property 'featureOne' is not concurrency-safe because it is not either conforming to 'Sendable' or isolated to a global actor; this is an error in Swift 6

/DerivedData/xcstrings-tool-dmlhbkyuqhmcebaijwuzkgpsrtoy/SourcePackages/plugins/xcstrings-tool.output/PluginTests/XCStringsToolPlugin/XCStringsTool/Localizable.swift
/DerivedData/xcstrings-tool-dmlhbkyuqhmcebaijwuzkgpsrtoy/SourcePackages/plugins/xcstrings-tool.output/PluginTests/XCStringsToolPlugin/XCStringsTool/Localizable.swift:260:171 Static property 'localizable' is not concurrency-safe because it is not either conforming to 'Sendable' or isolated to a global actor; this is an error in Swift 6

XCStringsToolTests
/Tests/XCStringsToolTests/GenerateTests.swift
/Tests/XCStringsToolTests/GenerateTests.swift:141:23 Static property 'sourceCode' is not concurrency-safe because it is not either conforming to 'Sendable' or isolated to a global actor; this is an error in Swift 6

/DerivedData/xcstrings-tool-dmlhbkyuqhmcebaijwuzkgpsrtoy/SourcePackages/checkouts/swift-snapshot-testing/Sources/SnapshotTesting/Snapshotting/String.swift
/DerivedData/xcstrings-tool-dmlhbkyuqhmcebaijwuzkgpsrtoy/SourcePackages/checkouts/swift-snapshot-testing/Sources/SnapshotTesting/Snapshotting/String.swift:11:21 Static property 'lines' is not concurrency-safe because it is not either conforming to 'Sendable' or isolated to a global actor; this is an error in Swift 6

@liamnichols liamnichols force-pushed the feature/swift-6-preparation branch from ca3ccf1 to a56ceb8 Compare May 29, 2024 21:48
@liamnichols
Copy link
Owner

I had to move the @MainActor annotations up to the class level in the tests. For some reason they were failing with the annotation on the functions.

@liamnichols
Copy link
Owner

Wait, that didn't work 👀 Maybe something related to pointfreeco/swift-snapshot-testing#822 (comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants