SmartRefreshLayout循环调用导致StackOverflowError堆栈溢出 #353

Jove-zhou · 2023-04-10T02:52:36Z

问题描述

SmartRefreshLayout现有版本存在某些特定情景导致刷新完成判断循环调用此问题由来已久没有完全解决

期望行为

能否集成一个轻量级刷新和自动加载三方库，或者仅提供自动加载回调

如何复现

任何业务相关问题没有fork仓库复现问题一律无法解决, 凭空猜测只会让问题晦涩难懂, 大量耽误项目维护时间

截图

Non-fatal Exception: java.lang.StackOverflowError: stack size 8188KB
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2855)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$6.run(SmartRefreshLayout.java:2994)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefresh(SmartRefreshLayout.java:3043)
at com.drake.brv.PageRefreshLayout.finishRefresh(PageRefreshLayout.kt:457)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefreshWithNoMoreData(SmartRefreshLayout.java:3056)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2855)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$6.run(SmartRefreshLayout.java:2994)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefresh(SmartRefreshLayout.java:3043)
at com.drake.brv.PageRefreshLayout.finishRefresh(PageRefreshLayout.kt:457)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefreshWithNoMoreData(SmartRefreshLayout.java:3056)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2855)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$6.run(SmartRefreshLayout.java:2994)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefresh(SmartRefreshLayout.java:3043)
at com.drake.brv.PageRefreshLayout.finishRefresh(PageRefreshLayout.kt:457)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefreshWithNoMoreData(SmartRefreshLayout.java:3056)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2855)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$6.run(SmartRefreshLayout.java:2994)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefresh(SmartRefreshLayout.java:3043)
at com.drake.brv.PageRefreshLayout.finishRefresh(PageRefreshLayout.kt:457)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefreshWithNoMoreData(SmartRefreshLayout.java:3056)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2855)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$6.run(SmartRefreshLayout.java:2994)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefresh(SmartRefreshLayout.java:3043)
at com.drake.brv.PageRefreshLayout.finishRefresh(PageRefreshLayout.kt:457)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefreshWithNoMoreData(SmartRefreshLayout.java:3056)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2855)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$6.run(SmartRefreshLayout.java:2994)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefresh(SmartRefreshLayout.java:3043)
at com.drake.brv.PageRefreshLayout.finishRefresh(PageRefreshLayout.kt:457)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefreshWithNoMoreData(SmartRefreshLayout.java:3056)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2855)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$6.run(SmartRefreshLayout.java:2994)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefresh(SmartRefreshLayout.java:3043)
at com.drake.brv.PageRefreshLayout.finishRefresh(PageRefreshLayout.kt:457)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefreshWithNoMoreData(SmartRefreshLayout.java:3056)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2855)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$6.run(SmartRefreshLayout.java:2994)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefresh(SmartRefreshLayout.java:3043)
at com.drake.brv.PageRefreshLayout.finishRefresh(PageRefreshLayout.kt:457)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefreshWithNoMoreData(SmartRefreshLayout.java:3056)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2855)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$6.run(SmartRefreshLayout.java:2994)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefresh(SmartRefreshLayout.java:3043)
at com.drake.brv.PageRefreshLayout.finishRefresh(PageRefreshLayout.kt:457)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefreshWithNoMoreData(SmartRefreshLayout.java:3056)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2855)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$6.run(SmartRefreshLayout.java:2994)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefresh(SmartRefreshLayout.java:3043)
at com.drake.brv.PageRefreshLayout.finishRefresh(PageRefreshLayout.kt:457)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishRefreshWithNoMoreData(SmartRefreshLayout.java:3056)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2855)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:480)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.dhgate.buyermob.ui.order.DHOrderCenterRepeatFragment.initObserve$lambda-9$lambda-8(DHOrderCenterRepeatFragment.kt:274)
at com.dhgate.buyermob.ui.order.DHOrderCenterRepeatFragment.$r8$lambda$nnS4UzGBLgrr3FPso16Izi2xGG0()
at com.dhgate.buyermob.ui.order.DHOrderCenterRepeatFragment$$ExternalSyntheticLambda4.onChanged(:4)
at androidx.lifecycle.LiveData.considerNotify(LiveData.java:133)
at androidx.lifecycle.LiveData.dispatchingValue(LiveData.java:151)
at androidx.lifecycle.LiveData.setValue(LiveData.java:309)
at androidx.lifecycle.MutableLiveData.setValue(MutableLiveData.java:50)
at androidx.lifecycle.LiveData$1.run(LiveData.java:93)
at android.os.Handler.handleCallback(Handler.java:942)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:226)
at android.os.Looper.loop(Looper.java:313)
at android.app.ActivityThread.main(ActivityThread.java:8757)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)

版本

BRV:1.3.90
Android:10.11.12.13
Gradle:
Android Studio:

liangjingkanji · 2023-04-10T12:24:52Z

你有更好的第三方库替代品吗?
你说的循环调用问题我没有遇到过, 也许是使用问题, 是必现吗?

Jove-zhou · 2023-04-11T02:49:13Z

1 还在找
从源码分析某个下拉刷新完成并且没有更多数据的场景下 mState一直是Refreshing且未走到2985 而一直执行2994 最后导致溢出
2 不是必现从用户量维度万分之一

liangjingkanji · 2023-04-16T16:06:35Z

我已经ForkSmartRefrashLayout仓库并且合并他的PR来避免产生此问题, 不过具体更新得等我有空再进行

但是此问题我无法复现会导致比较麻烦

Jove-zhou · 2023-04-17T07:05:32Z

好的感谢

liangjingkanji · 2023-04-17T07:24:24Z

如果你能发起pr修复就更好了，毕竟我无法复现此问题不太确定

Jove-zhou · 2023-04-18T08:55:39Z

我在尝试复现修复，目前有点眉目，等待下次发版后看反馈结果在 2023-04-17 15:24:35，"劉強東" ***@***.***> 写道：如果你能发起pr修复就更好了，毕竟我无法复现此问题不太确定 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

liangjingkanji · 2023-05-26T16:35:16Z

@Jove-zhou 问题有进展吗?

Jove-zhou · 2023-05-29T14:06:16Z

还未解决发件人: ***@***.*** ***@***.***> 代表 ��| ***@***.***> 日期: 星期六, 2023年5月27日 00:35 收件人: liangjingkanji/BRV ***@***.***> 抄送: Jove-zhou ***@***.***>, Mention ***@***.***> 主题: Re: [liangjingkanji/BRV] 集成的SmartRefreshLayout在完成刷新的判断中存在循环调用会导致堆栈溢出 (Issue #353) @Jove-zhou<https://github.com/Jove-zhou> 问题有进展吗? ― Reply to this email directly, view it on GitHub<#353 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA7GK5CAE5E5XW7IJGUOFZDXIDLU5ANCNFSM6AAAAAAWYQHBRU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

luomoBM · 2023-06-06T02:43:41Z

这个问题我遇到过，我的情况是这样的：

在 onRefresh 触发网络请求后，还未刷新数据时，此时 state 为 RefreshState.Refreshing
因为某种原因再次触发刷新方法，比如 autoRefresh、refresh、refreshing 等。因为之前的 state 已经是 RefreshState.Refreshing 了，这个时候，当步骤 1 的网络请求回来后，调用 addData 刷新，就会陷入问题所说的循环调用

这个可能是库的问题，没有阻止两次 refresh 的刷新并且会陷入循环调用。但是我遇到的这个问题应该是可以人为避免的，你可以检查一下你的代码是否是我这种情况

Jove-zhou · 2023-06-21T06:07:35Z

这个问题我遇到过，我的情况是这样的：

在 onRefresh 触发网络请求后，还未刷新数据时，此时 state 为 RefreshState.Refreshing

因为某种原因再次触发刷新方法，比如 autoRefresh、refresh、refreshing 等。因为之前的 state 已经是 RefreshState.Refreshing 了，这个时候，当步骤 1 的网络请求回来后，调用 addData 刷新，就会陷入问题所说的循环调用

这个可能是库的问题，没有阻止两次 refresh 的刷新并且会陷入循环调用。但是我遇到的这个问题应该是可以人为避免的，你可以检查一下你的代码是否是我这种情况

并非你所说的这种情况目前来看非Refreshing的状态下完成一样会有此问题：
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:468)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2857)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData (SmartRefreshLayout.java:3239)
com.drake.brv.PageRefreshLayout.finish (PageRefreshLayout.kt:431)
com.drake.brv.PageRefreshLayout.addData (PageRefreshLayout.kt:323)
com.drake.brv.PageRefreshLayout.addData$default (PageRefreshLayout.kt:279)

liangjingkanji · 2023-08-06T06:39:32Z

无法复现此问题, 但是遇到过发生问题的人但没有去解决

  } else if (mState == RefreshState.Loading && mRefreshFooter != null && mRefreshContent != null) {
      count++;
      mHandler.postDelayed(this, more);
      //提前设置 状态为 LoadFinish 防止 postDelayed 导致 finishLoadMore 过后，外部判断 state 还是 Loading
      notifyStateChanged(RefreshState.LoadFinish);
      return;
  }

但是没有进入这条件估计是mRefreshFooter或mRefreshContent为null

Jove-zhou · 2023-08-14T02:30:39Z

不仅如此还会走到延迟为0的情况已尝试多种方式仍无法避免

Non-fatal Exception: java.lang.StackOverflowError: stack size 8188KB
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2857)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:476)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2857)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:476)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2857)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:476)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2857)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:476)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2857)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:476)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2857)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:476)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2857)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:476)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2857)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:476)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2857)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:476)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2857)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:476)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.drake.brv.PageRefreshLayout.finish(PageRefreshLayout.kt:439)
at com.drake.brv.PageRefreshLayout.addData(PageRefreshLayout.kt:331)
at com.drake.brv.PageRefreshLayout.addData$default(PageRefreshLayout.kt:287)

liangjingkanji · 2023-08-14T02:56:10Z

让我能复现此问题我就能修复

TxcA · 2023-08-14T03:05:15Z

是否初始化?

👉 下拉刷新/上拉加载 - 初始化

SmartRefreshLayout.setDefaultRefreshHeaderCreator { context, layout -> MaterialHeader(this) }
SmartRefreshLayout.setDefaultRefreshFooterCreator { context, layout -> ClassicsFooter(this) }

@Jove-zhou

Cocoooo · 2023-08-15T14:00:36Z

同样遇到这个问题了... @liangjingkanji 有眉目了嘛

liangjingkanji · 2023-08-15T15:54:16Z

同样遇到这个问题了... @liangjingkanji 有眉目了嘛

这属于SmartRefreshLayout的bug, 我无法复现此问题所以无法修复

如果能让我复现此问题或者可以尝试反馈给SmartRefreshLayout作者

liangjingkanji · 2023-08-15T16:23:18Z

Duplicate of scwang90/SmartRefreshLayout#1470
应该和他问题相同, 但是我不清楚他这个Fragment返回是什么操作, 你们谁能复现

可能是你们在Fragment的View还未创建时就开始调用加载

ChawLoo · 2023-08-29T07:31:25Z

这问题我研究出来了，但这个问题是SmartRefreshLayout的问题，跟BRV没有关系

ChawLoo · 2023-08-29T08:54:44Z

Activity的 onCreate 中，对 RecyclerVIew 赋值

val data = mutableListOf<Any>().apply {
    for (i in 0..9) {
        when (i) {
            1, 2 -> add(FullSpanModel())
            else -> add(SimpleModel())
        }
    }
}
binding.refresh.addData(data) { false }

因为没有更多数据了，会调用 SmartRefreshLayout.finishRefreshWithNoMoreData()，而该方法最终会调用finishRefresh()，关键点在这里：

判断条件中 mRefreshHeader 为null导致没有进入方法更改状态，正常应该修改为RefreshFinish，从而导致最后调用setNoMoreData方法里面

    @Override
    public RefreshLayout setNoMoreData(boolean noMoreData) {
        if (mState == RefreshState.Refreshing && noMoreData) {
        //    ！！！！看这里            判断mState仍然处于Refreshing 且 noMoreData =true 至此进入递归循环调用
            finishRefreshWithNoMoreData();
        } else if (mState == RefreshState.Loading && noMoreData) {
            finishLoadMoreWithNoMoreData();
        } else if (mFooterNoMoreData != noMoreData) {
            //不重要
        }
        return this;
    }

为什么前面判断的 mRefreshHeader 为null 呢，查看了一下源码，发现初始化的起点在

问题点就在这里，自定义View的onAttachedToWindow 生命周期是这样的：
Act.onCreate -> Act.onResume -> Act.onAttachedToWindow -> View.onAttachedToWindow
所以一旦立马调用 finishRefreshWithNoMoreData 就会出现堆栈溢出的递归问题。
demo没问题是因为demo的列表都是在Fragment的onViewCreated 生命周期里面执行的，没有该问题，
我fork了，创建了一个TestAct，必现了
https://github.com/ChawLoo/BRV

liangjingkanji · 2023-08-30T01:45:35Z

大佬分析的很仔细, 有没比较好的解决方案 @ChawLoo

liangjingkanji · 2023-08-31T16:54:52Z

感谢 @ChawLoo 对此问题的复现和详细描述

我通过拦截PageRefreshLayout.setNoMoreData来避免循环调用

private var currentNoMoreData: Boolean? = null
override fun setNoMoreData(noMoreData: Boolean): RefreshLayout {
    if (mAttachedToWindow) {
        super.setNoMoreData(noMoreData)
    } else {
        if (currentNoMoreData != noMoreData) {
            currentNoMoreData = noMoreData
            super.setNoMoreData(noMoreData)
        }
    }
    return this
}

请升级至最新版本

liangjingkanji · 2023-08-31T17:03:10Z

在网络请求或异步任务快于Activity渲染就会导致此问题, 的确发生概率非常小

并且由于demo都在Fragment中的确无法复现此问题

Jove-zhou · 2023-09-11T13:54:53Z

已更新为最新版从线上看并不是此原因造成的

Non-fatal Exception: java.lang.StackOverflowError: stack size 8188KB
at com.drake.brv.PageRefreshLayout.setNoMoreData(PageRefreshLayout.kt:472)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:491)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMoreWithNoMoreData(SmartRefreshLayout.java:3239)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.setNoMoreData(SmartRefreshLayout.java:2857)
at com.drake.brv.PageRefreshLayout.setNoMoreData(PageRefreshLayout.kt:472)
at com.scwang.smart.refresh.layout.SmartRefreshLayout$7.run(SmartRefreshLayout.java:3134)
at com.scwang.smart.refresh.layout.SmartRefreshLayout.finishLoadMore(SmartRefreshLayout.java:3226)
at com.drake.brv.PageRefreshLayout.finishLoadMore(PageRefreshLayout.kt:491)

liangjingkanji · 2023-09-11T14:48:24Z

试下1.5.1版本, 我再次尝试修复 @Jove-zhou

implementation 'com.github.liangjingkanji:BRV:1.5.1'

liangjingkanji · 2023-09-12T14:45:14Z

@Jove-zhou 该旧版本1.5.1一律禁止重复调用, 你试下这个版本

Jove-zhou · 2023-09-13T02:23:44Z

好的

Jove-zhou · 2023-09-25T10:46:12Z

@Jove-zhou 该旧版本1.5.1一律禁止重复调用, 你试下这个版本

到现在为止没有再出现了

liangjingkanji · 2023-09-25T10:55:38Z

不知道为什么mAttachedToWindow判断竟然还无效

liangjingkanji · 2023-10-08T08:50:48Z

@Jove-zhou 该旧版本1.5.1一律禁止重复调用, 你试下这个版本

到现在为止没有再出现了

你能再换成1.5.2版本试下是否又会出现循环调用吗, 因为无法复现此问题, 所以我并不能确认改成1.5.1方案

Jove-zhou · 2023-10-09T06:28:24Z

1.5.2 之前用过有问题

Jove-zhou added the 寻求帮助 Extra attention is needed label Apr 10, 2023

liangjingkanji changed the title ~~集成的SmartRefreshLayout在完成刷新的判断中存在循环调用会导致堆栈溢出~~ SmartRefreshLayout循环调用导致StackOverflowError堆栈溢出 Aug 6, 2023

liangjingkanji added Bug Something isn't working and removed 寻求帮助 Extra attention is needed labels Aug 31, 2023

liangjingkanji closed this as completed in 10f29ba Aug 31, 2023

liangjingkanji added a commit that referenced this issue Sep 11, 2023

fix: #353 修复setNoMoreData重复调用

5e7dd9a

This was referenced Apr 30, 2024

PageRefreshLayout在refreshing后，失效无法回调和动画无法回弹问题 #439

Closed

修复PageRefreshLayout的Refreshing和refresh会导致刷新组件无法刷新的问题 #440

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SmartRefreshLayout循环调用导致StackOverflowError堆栈溢出 #353

SmartRefreshLayout循环调用导致StackOverflowError堆栈溢出 #353

Jove-zhou commented Apr 10, 2023

liangjingkanji commented Apr 10, 2023

Jove-zhou commented Apr 11, 2023

liangjingkanji commented Apr 16, 2023

Jove-zhou commented Apr 17, 2023

liangjingkanji commented Apr 17, 2023

Jove-zhou commented Apr 18, 2023 via email

liangjingkanji commented May 26, 2023

Jove-zhou commented May 29, 2023 via email

luomoBM commented Jun 6, 2023 •

edited

Loading

Jove-zhou commented Jun 21, 2023

liangjingkanji commented Aug 6, 2023

Jove-zhou commented Aug 14, 2023

liangjingkanji commented Aug 14, 2023

TxcA commented Aug 14, 2023

Cocoooo commented Aug 15, 2023

liangjingkanji commented Aug 15, 2023

liangjingkanji commented Aug 15, 2023 •

edited

Loading

ChawLoo commented Aug 29, 2023 •

edited

Loading

ChawLoo commented Aug 29, 2023 •

edited

Loading

liangjingkanji commented Aug 30, 2023 •

edited

Loading

liangjingkanji commented Aug 31, 2023 •

edited

Loading

liangjingkanji commented Aug 31, 2023 •

edited

Loading

Jove-zhou commented Sep 11, 2023

liangjingkanji commented Sep 11, 2023 •

edited

Loading

liangjingkanji commented Sep 12, 2023

Jove-zhou commented Sep 13, 2023

Jove-zhou commented Sep 25, 2023

liangjingkanji commented Sep 25, 2023

liangjingkanji commented Oct 8, 2023

Jove-zhou commented Oct 9, 2023

SmartRefreshLayout循环调用导致StackOverflowError堆栈溢出 #353

SmartRefreshLayout循环调用导致StackOverflowError堆栈溢出 #353

Comments

Jove-zhou commented Apr 10, 2023

问题描述

期望行为

如何复现

截图

版本

liangjingkanji commented Apr 10, 2023

Jove-zhou commented Apr 11, 2023

liangjingkanji commented Apr 16, 2023

Jove-zhou commented Apr 17, 2023

liangjingkanji commented Apr 17, 2023

Jove-zhou commented Apr 18, 2023 via email

liangjingkanji commented May 26, 2023

Jove-zhou commented May 29, 2023 via email

luomoBM commented Jun 6, 2023 • edited Loading

Jove-zhou commented Jun 21, 2023

liangjingkanji commented Aug 6, 2023

Jove-zhou commented Aug 14, 2023

liangjingkanji commented Aug 14, 2023

TxcA commented Aug 14, 2023

Cocoooo commented Aug 15, 2023

liangjingkanji commented Aug 15, 2023

liangjingkanji commented Aug 15, 2023 • edited Loading

ChawLoo commented Aug 29, 2023 • edited Loading

ChawLoo commented Aug 29, 2023 • edited Loading

liangjingkanji commented Aug 30, 2023 • edited Loading

liangjingkanji commented Aug 31, 2023 • edited Loading

感谢 @ChawLoo 对此问题的复现和详细描述

liangjingkanji commented Aug 31, 2023 • edited Loading

Jove-zhou commented Sep 11, 2023

liangjingkanji commented Sep 11, 2023 • edited Loading

liangjingkanji commented Sep 12, 2023

Jove-zhou commented Sep 13, 2023

Jove-zhou commented Sep 25, 2023

liangjingkanji commented Sep 25, 2023

liangjingkanji commented Oct 8, 2023

Jove-zhou commented Oct 9, 2023

luomoBM commented Jun 6, 2023 •

edited

Loading

liangjingkanji commented Aug 15, 2023 •

edited

Loading

ChawLoo commented Aug 29, 2023 •

edited

Loading

ChawLoo commented Aug 29, 2023 •

edited

Loading

liangjingkanji commented Aug 30, 2023 •

edited

Loading

liangjingkanji commented Aug 31, 2023 •

edited

Loading

liangjingkanji commented Aug 31, 2023 •

edited

Loading

liangjingkanji commented Sep 11, 2023 •

edited

Loading