[fix](cloud) fix double free when get_error_log_file_path

liaoxin01 · Sep 26, 2024 · 4e3371a · 4e3371a
1 parent 16d05dc
commit 4e3371a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/be/src/runtime/runtime_state.cpp b/be/src/runtime/runtime_state.cpp
@@ -434,6 +434,7 @@ Status RuntimeState::append_error_msg_to_file(std::function<std::string()> line,
 }
 
 std::string RuntimeState::get_error_log_file_path() {
+ std::lock_guard<std::mutex> l(_s3_error_log_file_lock);
  if (_s3_error_fs && _error_log_file && _error_log_file->is_open()) {
  // close error log file
  _error_log_file->close();

diff --git a/be/src/runtime/runtime_state.h b/be/src/runtime/runtime_state.h
@@ -735,6 +735,7 @@ class RuntimeState {
  std::shared_ptr<io::S3FileSystem> _s3_error_fs;
  // error file path on s3, ${bucket}/${prefix}/error_log/${label}_${fragment_instance_id}
  std::string _s3_error_log_file_path;
+ std::mutex _s3_error_log_file_lock;
 };
 
 #define RETURN_IF_CANCELLED(state) \