-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds support for kubernetes mounted private keys #1081
adds support for kubernetes mounted private keys #1081
Conversation
PostgreSQL recently changed the permissions it allows. This driver should use logic similar to |
65bf9f9
to
4d4470b
Compare
Hi @cbandy! I've updated the PR to match the permission check in the PostgreSQL! |
401ffb4
to
7da0995
Compare
Sorry about the linter errors, I've fixed them now and just to be safe I ran the test suite again. |
Hey @rafiss! This is the PR we spoke about 1:1 :) |
7da0995
to
d8917fa
Compare
@catj-cockroach This does not appear to resolve the k8s fsGroup issue, as soon as the container is running as non-root and you need to set fsGroup it does not work, as this PR only allows 0640 permission if the mounted secret is owned by root. |
@arjantop-cai you'll also need to set the |
@catj-cockroach my bad, skaffold just did not rebuild the image with the new pq version, all works as expected 👍 |
This PR adds support for using private keys mounted in Kubernetes. It should partially fix issue #825 at least in Kubernetes, with the use of
fsGroup
in thesecurityContext
anddefaultMode
on the mounted secret.