-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12 support #645
Comments
Yup, we'd be happy to support this. Would you be willing to make a PR changing the wheel building script? Once this works I'll be happy to tag a new release to PyPI. |
Most likely just needs a version bump of cibuildwheel here |
@jameskermode Please check PR #649. |
@jameskermode sorry that I did not react! I overlooked the mentions for some reason! thanks @ATM-Jahid for working on this! |
#649 is merged, but unfortunately the wheel builder doesn't run on PRs and I can now see it's failing, I think due to old manylinux containers not supporting Python 3.12 so we'll need to do a bit more work on this. Logs: https://github.com/libAtoms/QUIP/actions/runs/9767786532/job/26963837065#step:5:283 |
just to note that materialsproject/atomate2#992 is currently failing CI due to a missing
i'll go ahead and restrict it for now
|
Noted, thanks. I don't think I will have the time to continue to update quippy for new Python releases, so restricting versions is the best thing to do for now. If anyone else would be willing to pick up from where @ATM-Jahid left off I'm sure it would be much appreciated. |
Thanks @jameskermode. I will check if we can pick this up in the future. At least Python 3.12 support would be great. |
@jameskermode are you doing the updates manually, or can we have the github CI create them automatically for every python version that's available? |
List is manual. But that's not the main problem, it's the version compatibilities discussed above which need real work to fix. |
Anyone trying to help with python 3.12 support should read this comment. |
I am wondering if there is a chance for a Python 3.12 version.
The text was updated successfully, but these errors were encountered: