Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 support #645

Open
JaGeo opened this issue Jun 8, 2024 · 11 comments · Fixed by #649
Open

Python 3.12 support #645

JaGeo opened this issue Jun 8, 2024 · 11 comments · Fixed by #649

Comments

@JaGeo
Copy link

JaGeo commented Jun 8, 2024

I am wondering if there is a chance for a Python 3.12 version.

@jameskermode
Copy link
Member

Yup, we'd be happy to support this. Would you be willing to make a PR changing the wheel building script?
https://github.com/libAtoms/QUIP/blob/public/.github/workflows/build-wheels.yml

Once this works I'll be happy to tag a new release to PyPI.

@jameskermode
Copy link
Member

Most likely just needs a version bump of cibuildwheel here

@ATM-Jahid
Copy link
Contributor

@jameskermode Please check PR #649.

@JaGeo
Copy link
Author

JaGeo commented Jul 1, 2024

@jameskermode sorry that I did not react! I overlooked the mentions for some reason!

thanks @ATM-Jahid for working on this!

@jameskermode
Copy link
Member

#649 is merged, but unfortunately the wheel builder doesn't run on PRs and I can now see it's failing, I think due to old manylinux containers not supporting Python 3.12 so we'll need to do a bit more work on this.

Logs: https://github.com/libAtoms/QUIP/actions/runs/9767786532/job/26963837065#step:5:283

@janosh
Copy link

janosh commented Sep 26, 2024

just to note that materialsproject/atomate2#992 is currently failing CI due to a missing quippy-ase wheel for 3.12:

╰─▶ Because quippy-ase==0.9.14 has no wheels with a matching Python ABI tag
and atomate2[strict-forcefields]==0.0.1 depends on quippy-ase==0.9.14...

i'll go ahead and restrict it for now

"quippy-ase==0.9.14; python_version < '3.12'",

@jameskermode
Copy link
Member

Noted, thanks. I don't think I will have the time to continue to update quippy for new Python releases, so restricting versions is the best thing to do for now. If anyone else would be willing to pick up from where @ATM-Jahid left off I'm sure it would be much appreciated.

@JaGeo
Copy link
Author

JaGeo commented Sep 28, 2024

Thanks @jameskermode. I will check if we can pick this up in the future. At least Python 3.12 support would be great.

@bernstei
Copy link
Contributor

@jameskermode are you doing the updates manually, or can we have the github CI create them automatically for every python version that's available?

@jameskermode
Copy link
Member

List is manual. But that's not the main problem, it's the version compatibilities discussed above which need real work to fix.

@ATM-Jahid
Copy link
Contributor

Anyone trying to help with python 3.12 support should read this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants