Bump min supported Python to 3.10 #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ADME.md add badge showing min supported Python version
janosh
added
pkg
|
It's already time for a new conda env 😨. Thanks for this @janosh. It makes sense to follow suit with pymatgen. Happy to add the strict option. |
utf
approved these changes
Sep 26, 2024
| @@ -5,6 +5,7 @@ | |||
| [](https://pypi.org/project/atomate2) | |||
|  | |||
There was a problem hiding this comment.
Here is a second python badge still listing 3.9.
There was a problem hiding this comment.
that badge pulls the data it displays from PyPI, so will auto-update once this PR is merged and released
There was a problem hiding this comment.
Oki, good to know :)
|
@utf the required CI runs for auto-merging need updating. 3.9 is still required but should be replaced with 3.12 edit: nvm, already done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following suit with
pymatgenwhich in turn followsnumpy,scipyand the rest of the NumFOCUS stack, this PR drops Python 3.9 support.@utf curious to hear your thoughts. we may want to add 3.12 to CI in the same PR. another open question is whether we want to set
zip's newstrictkeyword toTrue. it defaults toFalsewhich preserves the old behavior of stopping whenever the 1st iterator is exhausted.Trueinstead throws an error if all iterators don't have the same length