-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump min supported Python to 3.10 #992
Conversation
…ADME.md add badge showing min supported Python version
It's already time for a new conda env 😨. Thanks for this @janosh. It makes sense to follow suit with pymatgen. Happy to add the strict option. |
@@ -5,6 +5,7 @@ | |||
[![pypi version](https://img.shields.io/pypi/v/atomate2?color=blue)](https://pypi.org/project/atomate2) | |||
![supported python versions](https://img.shields.io/pypi/pyversions/atomate2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a second python badge still listing 3.9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that badge pulls the data it displays from PyPI, so will auto-update once this PR is merged and released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oki, good to know :)
@utf the required CI runs for auto-merging need updating. 3.9 is still required but should be replaced with 3.12 edit: nvm, already done |
* obj.__class__.__name__ -> type(maker).__name__ * bump ruff target-version to py310 and fix errors * pyproject bump requires-python = ">=3.9", testing.yml drop 3.9 CI, README.md add badge showing min supported Python version * missed some python-version: 3.9 in GH wfs * fix outdated docs saying atomate2 supports py3.8+ * add Python 3.12 to supported versions and test in CI * fix multiple level 1 headings in docs/user/codes/openmm.md * quippy-ase==0.9.14; python_version < '3.12' * "tblite>=0.3.0; python_version < '3.12'" * try zip(strict=True) everywhere * ruff --------- Co-authored-by: Alex Ganose <utf@users.noreply.github.com>
following suit with
pymatgen
which in turn followsnumpy
,scipy
and the rest of the NumFOCUS stack, this PR drops Python 3.9 support.@utf curious to hear your thoughts. we may want to add 3.12 to CI in the same PR. another open question is whether we want to set
zip
's newstrict
keyword toTrue
. it defaults toFalse
which preserves the old behavior of stopping whenever the 1st iterator is exhausted.True
instead throws an error if all iterators don't have the same length