DirichletBoundaries should be a vector of unique_ptrs #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirichletBoundaries was previously responsible for deleting, but not allocating, the pointers that it held, which made understanding the ownership semantics a bit challenging and caused us to have to define a non-trivial destructor (in dof_map_constraints.C).
|
Job Coverage on 5af4570 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
roystgnr
approved these changes
May 9, 2022
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirichletBoundaries was previously responsible for deleting, but not
allocating, the pointers that it held, which made understanding the
ownership semantics a bit challenging and caused us to have to define
a non-trivial destructor (in dof_map_constraints.C).