XML Parsing for TransportMixture #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can encapsulate the parsing of each specific part of the transport section into a separate function. Eventually, we should just do unit conversion, but for now, let's at least make the user aware if they changed the unit and were expecting good things to happen.
This implements the function read_transport_data for the XMLParser. Thus we should be able to now parse transport properties from an XML file in Antioch.
This used to only test thermo, but now tests lots of other things so let's remove the "thermo_" from the variable name.
We use the GRI3 XML file and test the three species that we checked in the other parts of the GRI 3 unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #249.
Implements parsing for the
TransportMixtureobject using our XMLParser. Unit tested on GRI 3.0 XML file. I didn't implement unit conversion here, but at least throw an error if the incorrect unit is specified so we don't get any surprises.