Merge pull request #1400 from evoskuil/master

Comments.
libbitcoin · Feb 17, 2024 · 1d7a13c · 1d7a13c
2 parents 9031fdc + 621b793
commit 1d7a13c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/include/bitcoin/system/data/memory.hpp b/include/bitcoin/system/data/memory.hpp
@@ -32,7 +32,7 @@ namespace system {
 BC_PUSH_WARNING(NO_THROW_IN_NOEXCEPT)
 
 // shared_ptr moves are avoided in vector population by using 'new' and passing
-// to shared_pointer constrcut a raw pointer via std::vector.emplace_back:
+// to shared_pointer construct a raw pointer via std::vector.emplace_back:
 // std::vector.emplace_back(new block{...}).
 // Otherwise emplace_back copies the shared pointer, just as would push_back:
 // std::vector.emplace_back(std::make_shared<block>(block{...})).

diff --git a/include/bitcoin/system/wallet/addresses/witness_address.hpp b/include/bitcoin/system/wallet/addresses/witness_address.hpp
@@ -125,6 +125,7 @@ class BC_API witness_address
         const std::string& prefix=mainnet) NOEXCEPT;
 
     // version_0_p2sh
+    // NOTE: ec_secret ends up here, not above in construction of ec_private.
     witness_address(const hash_digest& script_hash,
         const std::string& prefix=mainnet) NOEXCEPT;
     witness_address(const chain::script& script,

diff --git a/include/bitcoin/system/wallet/context.hpp b/include/bitcoin/system/wallet/context.hpp
@@ -246,7 +246,7 @@ struct BC_API context
 
     uint16_t versions() const NOEXCEPT
     {
-        // TODO: inconsistency order: public, private
+        // TODO: inconsistenct order: public, private
         return ec_private::to_versions(address_version, wif_prefix);
     }
 };