Fix unsoundness in InsertMap
#1041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our InsertMap type is not working correctly in the presence of reallocations of the internally used hash map. Specifically, because our insertion does not require a mutable reference, users may hold references to entries across insertions. If the hash map were to reallocate as part of the insertion, the references would effectively be dangling, which is undefined behavior. Fix the problem by heap allocating all values in the hash map. Signed-off-by: Daniel Müller <deso@posteo.net>
danielocfb
force-pushed
the
topic/fix-insert-map
branch
from
9b28a83 to
473654a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
==========================================
+ Coverage 94.85% 94.96% +0.11%
==========================================
Files 60 60
Lines 11091 11093 +2
==========================================
+ Hits 10520 10535 +15
+ Misses 571 558 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our InsertMap type is not working correctly in the presence of reallocations of the internally used hash map. Specifically, because our insertion does not require a mutable reference, users may hold references to entries across insertions. If the hash map were to reallocate as part of the insertion, the references would effectively be dangling, which is undefined behavior.
Fix the problem by heap allocating all values in the hash map.