Move KASLR logic into "generic" kernel module #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it turns out we will need the KASLR logic not just in normalization code but also in parts of the symbolization logic. As such, let's move the containing module out of the normalize functionality and into the more generic parts of the crate. Signed-off-by: Daniel Müller <deso@posteo.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 58 58
Lines 10742 10742
=======================================
Hits 10185 10185
Misses 557 557 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out we will need the KASLR logic not just in normalization code but also in parts of the symbolization logic. As such, let's move the containing module out of the normalize functionality and into the more generic parts of the crate.