Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror: Add .mailmap to the repository, sync with kernel's #142

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

qmonnet
Copy link
Member

@qmonnet qmonnet commented Apr 25, 2024

Add a script to grep for the relevant entries in the .mailmap file of the kernel repository, and use it to build a .mailmap file for the mirror repo.

Add a script to grep for the relevant entries in the .mailmap file of
the kernel repository, and use it to build a .mailmap file for the
mirror repo.

Signed-off-by: Quentin Monnet <qmo@kernel.org>
@qmonnet qmonnet merged commit 744e0cd into libbpf:main Apr 25, 2024
3 checks passed
@qmonnet qmonnet deleted the pr/mailmap branch April 25, 2024 10:52
@qmonnet
Copy link
Member Author

qmonnet commented Apr 25, 2024

Cc @anakryiko just for your information, in case you were interested in a .mailmap for libbpf.

@anakryiko
Copy link
Member

how is this .mailmap file used? Is Github using this automatically?

If you are up sending PR, we can add it to libbpf repo and maybe include it into sync workflow.

@qmonnet
Copy link
Member Author

qmonnet commented Apr 25, 2024

how is this .mailmap file used? Is Github using this automatically?

The .mailmap is used by git to remap names or emails in commit logs, typically if someone didn't use a canonical form for their name, or if they changed email address. See the documentation for details.

Concretely, if you cloned the repository and run git log in it, you would no longer see my @isovalent.com email for the commits I authored, only the @kernel.org (the sign-offs and other tags in commit description remain unchanged, though).

Alas, GitHub does not support mailmap as far as I know. So it's only when you look locally at the logs, which makes the interest of the whole thing limited, but I thought it would still be nice to replicate this aspect from the kernel repo and account for email address changes when relevant.

If you are up sending PR, we can add it to libbpf repo and maybe include it into sync workflow.

Should be easy enough, the update script I merged works just as well for libbpf, and we can call it from the sync-up script. I'll send the PR.

@qmonnet
Copy link
Member Author

qmonnet commented Apr 25, 2024

libbpf/libbpf#800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants