Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbpf-rs: Fix clippy error in examples/query #180

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

insearchoflosttime
Copy link
Collaborator

Signed-off-by: Joanne Koong joannekoong@gmail.com

@@ -31,7 +31,7 @@ fn prog() {

fn map() {
for map in query::MapInfoIter::default() {
println!("name={:<16} type={}", map.name, map.ty.to_string(),);
println!("name={:<16} type={}", map.name, map.ty,);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that trailing coma necessary? looks weird

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust supports trailing commas but I agree it looks unnatural. I will remove this.

@insearchoflosttime
Copy link
Collaborator Author

insearchoflosttime commented Jan 24, 2022

This check is still failing due to clippy complaining about "error: this implementation is unsound, as some fields in RunqslowerSkel<'a> are !Send" but this warning is misguided and fixed in Rust 1.58 as per rust-lang/rust-clippy#8045. We'll need to update the build to use the latest version of Rust, which should fix this complaint (verified locally)

Signed-off-by: Joanne Koong <joannekoong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants