Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbpf-rs: Add more setter functionalities on open maps #249

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

insearchoflosttime
Copy link
Collaborator

@insearchoflosttime insearchoflosttime commented Jul 26, 2022

As part of the initiative to reach feature-parity with libbpf-1.0, this
commit adds:

  • set_map_flags
  • set_numa_node
  • set_map_extra
  • set_autocreate
  • set_pin_path

Signed-off-by: Joanne Koong joannekoong@gmail.com

@insearchoflosttime insearchoflosttime changed the title libbpf-rs: Add setter functionalities on open maps libbpf-rs: Add more setter functionalities on open maps Jul 26, 2022
Copy link
Collaborator

@danielocfb danielocfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, two questions, though.

libbpf-rs/src/map.rs Outdated Show resolved Hide resolved
libbpf-rs/src/map.rs Show resolved Hide resolved
@insearchoflosttime
Copy link
Collaborator Author

Thanks for taking a look @danielocfb !

Copy link
Collaborator

@danielocfb danielocfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation! To me this change looks good.

As part of the initiative to reach feature-parity with libbpf-1.0, this
commit adds:

* set_map_flags
* set_numa_node
* set_map_extra
* set_autocreate
* set_pin_path

Signed-off-by: Joanne Koong <joannekoong@gmail.com>
@insearchoflosttime
Copy link
Collaborator Author

update: remove naming change for "set_map_ifindex" -> "set_ifindex". Will make this naming change as part of its own commit.

@insearchoflosttime insearchoflosttime merged commit a8073fa into master Jul 26, 2022
@insearchoflosttime insearchoflosttime deleted the map_setter branch July 26, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants