Shared Library for Visual Studio #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkoi
force-pushed
the
so-for-visual-studio
branch
3 times, most recently
from
224b6d1 to
d0d2000
Compare
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
We have tried to statically link the built libcompat into built libcheck in CMake without success. With autotools (libtool et.al.) this is most likely very easy but there is no support on Windows. So instead of building libcompat separately we incorporate the necessary parts of libcompat code directly into libcheck when building libcheck. Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Target check is specifically a static library
mikkoi
force-pushed
the
so-for-visual-studio
branch
from
d0d2000 to
cf07d23
Compare
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Variable PROJECT_VERSION was not yet in use when check_stdint.h configuration was updated. Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
File check.pc.in is shared with Autotools and CMake build. File uses variable 'VERSION'. Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
For compatibility with the Autotools build which only uses three parts: major, minor and patch. CMake allows four components in version numbering: major, minor, patch and tweak. Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Removing the set(MEMORY_LEAKING_TESTS_ENABLED) which had no effect on the build. The new CMake build option uses verb-first structure (do something on something: e.g. ENABLE/BUILD) like other build options. The definition itself is "MEMORY_LEAKING_TESTS_ENABLED" and only enabled in the tests/ subdirectory. Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Already included in the project root CMakeLists.txt Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
mikkoi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to create both a statically linked library and a shared library with CMake. Currently CMake build only builds a statically linked library. Earlier tests showed that it works in Linux but there were failures in older Visual Studios.