add empty() for cpr::Cookies #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COM8
requested changes
Apr 28, 2024
There was a problem hiding this comment.
@xiaoloudongfeng thanks! Please make it const and we are ready to go.
cpr/cookies.cpp
Outdated
| @@ -100,6 +100,10 @@ void Cookies::emplace_back(const Cookie& str) { | |||
| cookies_.emplace_back(str); | |||
| } | |||
|
|
|||
| bool Cookies::empty() { | |||
There was a problem hiding this comment.
Suggested change
| bool Cookies::empty() { | |
| bool Cookies::empty() const { |
I would suggest making it const.
include/cpr/cookies.h
Outdated
| @@ -80,6 +80,7 @@ class Cookies { | |||
| const_iterator cbegin() const; | |||
| const_iterator cend() const; | |||
| void emplace_back(const Cookie& str); | |||
| bool empty(); | |||
There was a problem hiding this comment.
Suggested change
| bool empty(); | |
| [[nodiscard]] bool empty() const; |
|
@COM8 sorry I was careless, it has been fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.