Resolve CURLOPT_SSL_OPTIONS issues

[gentooise]

Closes #1127

Note for reviewers: I tried to keep equivalent #ifdef conditions, but I'm not really sure on the history/rationale of those. Please double check.

[COM8]

Only one minor change is required. Thanks for fixing it!

Your assumption on version check macros is correct. The one you removes is redundant.

[gentooise]

Is there some pipeline issue I may help with? @COM8

[COM8]

I'm not sure why it's failing right now. To me it looks like the OpenSSL windows install is not working properly again.

[COM8]

I triggered master again to see if it happens there as well.

[COM8]

@gentooise Looks like it's something related to this MR. Is there any way you can debug this on Windows with OpenSSL?

Ref: https://github.com/libcpr/cpr/blob/master/.github/workflows/ci.yml#L224

[gentooise]

@gentooise Looks like it's something related to this MR. Is there any way you can debug this on Windows with OpenSSL?

Ref: https://github.com/libcpr/cpr/blob/master/.github/workflows/ci.yml#L224

I might try but I need some help. Which Windows and OpenSSL version are used for the CI tests?
Can you provide steps to run the tests?

[COM8]

Awesome!
Not sure if you have access to the build log, but here it is: job-logs.txt

It's using:

• Microsoft Windows Server 2022 - 10.0.20348 but I'd say any windows >= 10 is good to go here.
• openssl v3.3.2 via chocolatey.org

[gentooise]

Awesome! Not sure if you have access to the build log, but here it is: job-logs.txt

It's using:

• Microsoft Windows Server 2022 - 10.0.20348 but I'd say any windows >= 10 is good to go here.
• openssl v3.3.2 via chocolatey.org

Thank you.
I'm following these steps (taken from your job-logs.txt) but I get "No tests were found!!!":

cmake -DCMAKE_BUILD_TYPE=Release -B build -G "Visual Studio 17 2022"
cmake --build build --config Release --parallel 4
ctest -C Release --repeat until-pass:5 --output-on-failure

What am I missing? @COM8

[COM8]

Try adding -DCPR_BUILD_TESTS=ON when configuring CMake to enable Tests.

[COM8]

I looked into it closely again and every time different tests are failing. This to me indicates there is nothing wrong with your code changes but in general something with the tests.

Approving/Merging

Also Clang-Tidy failing has nothing to do with this MR. It just got updated.

[gentooise]

I looked into it closely again and every time different tests are failing. This to me indicates there is nothing wrong with your code changes but in general something with the tests.

Approving/Merging

Also Clang-Tidy failing has nothing to do with this MR. It just got updated.

Yesterday I also managed to run the tests, but didn't have time to report the results. Anyway, I can confirm this: I've also seen random/unrelated tests failing... (AsyncGetTests in particular).

If anyone wants to troubleshoot, I collected the steps to run the tests from scratch, starting from a clean Windows Server VM (I've used this vagrant box https://app.vagrantup.com/peru/boxes/windows-server-2022-standard-x64-eval).

Steps used (from admin PowerShell):

# install choco
Set-ExecutionPolicy Bypass -Scope Process -Force; [System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072; iex ((New-Object System.Net.WebClient).DownloadString('https://community.chocolatey.org/install.ps1'))
# restart powershell here
choco install visualstudio2022community
choco install visualstudio2022buildtools
choco install visualstudio2022-workload-vctools --package-parameters "--includeOptional"
choco install openssl --version=3.3.2
choco install git.install
choco install cmake --installargs 'ADD_CMAKE_TO_PATH=System' --apply-install-arguments-to-dependencies
# restart powershell here
git clone https://github.com/gentooise/cpr.git
cd cpr
git checkout 8497eac1c7124cb53ac3d0534a3093f1b9e2a9b4 # checkout the relevant commit here
cmake -DCMAKE_BUILD_TYPE=Release -DCPR_FORCE_OPENSSL_BACKEND=ON -DCPR_BUILD_TESTS=ON -DCPR_BUILD_TESTS_SSL=ON -B build -G "Visual Studio 17 2022"
cmake --build build --config Release --parallel 4
cd build
ctest -C Release --repeat until-pass:5 --output-on-failure