Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public cpr::Session::GetSharedPtrFromThis #1148

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

COM8
Copy link
Member

@COM8 COM8 commented Nov 24, 2024

GetSharedPtrFromThis was always intended to be public. This PR fixes this. Ref #1145.

@COM8 COM8 added the Bug 🐛 label Nov 24, 2024
@COM8 COM8 added this to the CPR 1.11.x milestone Nov 24, 2024
@COM8 COM8 self-assigned this Nov 24, 2024
@COM8 COM8 force-pushed the feature/public_get_shared_from_this branch from 89f179c to cab8235 Compare November 24, 2024 05:48
@COM8 COM8 linked an issue Nov 24, 2024 that may be closed by this pull request
@COM8 COM8 merged commit 1e77021 into master Nov 24, 2024
101 of 104 checks passed
@COM8 COM8 deleted the feature/public_get_shared_from_this branch November 24, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is Session::GetSharedPtrFromThis mistakenly marked as private?
1 participant