Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NuGet: Fix VS2022 compatibility #912

Merged
merged 1 commit into from
May 15, 2023
Merged

NuGet: Fix VS2022 compatibility #912

merged 1 commit into from
May 15, 2023

Conversation

sven-molkenstruck
Copy link
Contributor

  • Move AdditionalIncludeDirectories section from libcpr.props to libcpr.targets.
  • Add %(AdditionalIncludeDirectories).
  • Minor cleanup of line indentation in libcpr.probs.

This fixes my issue #902 in Visual Studio 2022 Version 17.5.5.
However I have not tested any other environments.

NuGet: Move AdditionalIncludeDirectories section from libcpr.props to…
34273ff 
… libcpr.targets. Add %(AdditionalIncludeDirectories). Minor cleanup of line indentation.
@sven-molkenstruck sven-molkenstruck mentioned this pull request May 15, 2023
Closed
COM8
COM8 approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I will trigger a new NuGet build as soon as this has been merged.

@COM8 COM8 linked an issue May 15, 2023 that may be closed by this pull request
NuGet package: 'AdditionalIncludeDirectories' not working in VS 2022 #902
Closed
@COM8 COM8 merged commit f26502b into libcpr:master May 15, 2023
COM8 added a commit that referenced this pull request May 15, 2023
@COM8
Merge pull request #912 from Sven-HP/fix-nuget-vs2022
16f832b 
NuGet: Fix VS2022 compatibility
COM8 added a commit that referenced this pull request May 15, 2023
@COM8
Merge pull request #912 from Sven-HP/fix-nuget-vs2022
bdde915 
NuGet: Fix VS2022 compatibility
@sven-molkenstruck sven-molkenstruck deleted the fix-nuget-vs2022 branch May 15, 2023 11:54
@sven-molkenstruck
Copy link
Contributor Author

Thank you @COM8
Your new NuGet build 1.10.4 works fine for me. :-)

@BrewTestBot BrewTestBot mentioned this pull request Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@COM8 COM8 COM8 approved these changes

Assignees
No one assigned
Labels
Bug 🐛 Build 👷 Windows 📺
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NuGet package: 'AdditionalIncludeDirectories' not working in VS 2022
2 participants
@sven-molkenstruck @COM8