Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only set CURLSSLOPT_NATIVE_CA if curl version >= 7.71.0 #985

Merged
merged 1 commit into from
Nov 21, 2023
Merged

only set CURLSSLOPT_NATIVE_CA if curl version >= 7.71.0 #985

merged 1 commit into from
Nov 21, 2023

Conversation

flixr
Copy link
Contributor

@flixr flixr commented Nov 16, 2023

only seems to be needed for windows and minimum curl version there is already checked in CMakeLists...

fixes #960

@flixr
only set CURLSSLOPT_NATIVE_CA if curl version >= 7.71.0
641e293 
only seems to be needed for windows and minimum curl version there is
already checked in CMakeLists...
COM8
COM8 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@COM8 COM8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Ref: https://curl.se/libcurl/c/CURLOPT_SSL_OPTIONS.html

@COM8 COM8 merged commit 6916a53 into libcpr:master Nov 21, 2023
37 of 53 checks passed
@flixr flixr deleted the ubuntu20.04_fix_sytem_curl branch November 27, 2023 08:24
@BrewTestBot BrewTestBot mentioned this pull request Oct 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@COM8 COM8 COM8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cmake build failed
2 participants
@flixr @COM8