Update Timer services so that YAML configuration is not required #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #90 by no longer requiring using YAML to call the Timer Service (the messages about needing YAML at the bottom are gone now).
We have a minutes selector that only goes within the permissible range (0-540) and an indicator that we are looking at minutes, as opposed to just a random textbox from before.
The service can only be called on the Fan entity, so we have limited selection to the Fan's domain too. This used to be open to all entities, including the Dyson climate one (which wouldn't have worked).
In a future PR, we can add a numeric textbox for this against the device. This will alleviate the need to use the Service in most cases.