Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-forge packaging #15

Open
loriab opened this issue Feb 17, 2023 · 5 comments
Open

conda-forge packaging #15

loriab opened this issue Feb 17, 2023 · 5 comments

Comments

@loriab
Copy link
Collaborator

loriab commented Feb 17, 2023

Hi @slipchenko, I wanted to let you know that I'm finally packaging libefp (and pylibefp) on conda-forge, so it'll be more broadly available than from the -c psi4 channel. conda-forge/staged-recipes#22027

  • Let me know if you (or someone else) ought to be a maintainer, too.
  • What's being packaged is the fairly old v1.5, since that's what I know works with Psi4. I can probably update that in future (though I think the latest sync with Q-Chem removed some functions we use).
  • The c-f packaging will do the C library and several Py versions across Linux, Mac, and Windows
  • The CMake in libefp (and pylibefp) is looking a little rusty. A more rational arrangement might be for me to PR all the python stuff from https://github.com/loriab/pylibefp/tree/master/pylibefp to this repo. It wouldn't change your dependencies unless someone LIBEFP_ENABLE_PYTHON=ON, at which point C++, Pybind11, Python, etc. are required. sound ok?

Please let me know if you've any questions, objections, etc.

@slipchenko
Copy link

Hi @loriab, this is terrific news! Thanks for your effort!
I would like to be a maintainer too.
It would be great to update the packaged libefp to a newer version though, as we added quite a bit of useful features recently. I would love to help with bringing the most recent libefp in sync with Psi4. Should we talk over zoom sometime next week?
Thanks again!

@loriab
Copy link
Collaborator Author

loriab commented Feb 17, 2023

Great, I've added you to the recipe. Please post at conda-forge/staged-recipes#22027 that you're willing to be a maintainer.

Sure, glad to talk next week to make plans. Any time other than W or Th afternoons works for me. I'm not going to be able to actually work on updating/reconciliation until mid-March, though.

@slipchenko
Copy link

Oh, I do not know how to add myself as a maintainer there :( I guess it is not too urgent, you can show me when we talk next week.

Would Friday Feb. 24 at 10 or 11 am work for you? Thanks!

@loriab
Copy link
Collaborator Author

loriab commented Feb 18, 2023

I've already added you. You need to make a comment on the PR (like this conversation) saying you're ok with being a maintainer (the reviewers want to make sure maintainers are volunteers, not conscripts :-).

Sure, anytime Friday morning works for me. lmk which time and time zone. Thanks!

@slipchenko
Copy link

slipchenko commented Feb 19, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants