Skip to content
This repository has been archived by the owner on May 14, 2020. It is now read-only.

Expand the README #261

Merged
merged 40 commits into from
Mar 9, 2020
Merged

Expand the README #261

merged 40 commits into from
Mar 9, 2020

Conversation

thewilkybarkid
Copy link
Contributor

@thewilkybarkid thewilkybarkid commented Feb 28, 2020

Adds details about the app, how to run it, how to develop, and badges.

@thewilkybarkid thewilkybarkid added the 📖 Docs Improvements or additions to documentation label Feb 28, 2020
@thewilkybarkid thewilkybarkid marked this pull request as ready for review March 5, 2020 11:10
@thewilkybarkid thewilkybarkid requested a review from a team as a code owner March 5, 2020 11:10
README.md Outdated
Comment on lines 96 to 99
4. Access the Article Store entry point:

```shell
curl --verbose localhost:8080
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth showing how to run a Hydra console instead?

Co-Authored-By: David Moulton <2893480+davidcmoulton@users.noreply.github.com>
Co-Authored-By: Joel Summerfield <52923935+NuclearRedeye@users.noreply.github.com>
@davidcmoulton
Copy link
Member

(A few occurrences): the first line of output running curl --verbose localhost:8080 is Rebuilt URL to: localhost:8080/

So the text should probably read

curl --verbose localhost:8080/

from the get go.

@thewilkybarkid
Copy link
Contributor Author

thewilkybarkid commented Mar 5, 2020

Maybe curl --include http://localhost:8080/ to just show the full response too.

(Though I don't see the Rebuilt URL.)

Copy link
Member

@BlueReZZ BlueReZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very succinct, good use of collapsible sections. I've not tried to follow the instructions but assuming they all run, then it looks good.

@thewilkybarkid thewilkybarkid merged commit d66cdf4 into libero:master Mar 9, 2020
@thewilkybarkid thewilkybarkid deleted the readme branch March 9, 2020 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📖 Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants