This repository was archived by the owner on Nov 21, 2019. It is now read-only.
[WIP] Use XLIFF resname #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewilkybarkid
commented
Dec 21, 2018
|
|
||
| - stage: Test | ||
| name: Symfony 4.0 | ||
| name: Symfony 4.1 |
Contributor
Author
There was a problem hiding this comment.
This is the problem with using the full stack, individual components are versioned (and symfony/translation won't work with 4.0). Would prefer a way to use each component at that version where possible.
Contributor
Author
There was a problem hiding this comment.
Symfony specific, but wonder if symfony/force-lowest#2 (comment) works...
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Wondered if symfony/flex#412 would fix, but didn't (https://travis-ci.com/libero/content-api-bundle/jobs/175370448). Opened symfony/flex#473.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been looking in how to use XLIFF better:
@resnamecan be used as the key, while@target-languageand<target>don't have to be present. So for the source language, we're not translating. When we do translate, we'd add@target-languageand<target>. This makes it clearer since the English<source>will remain in the translation file.We don't have a use for
@id, but it's required so I've left it sequential.