Run with uWSGI usage #13

giorgiosironi · 2018-08-17T17:36:56Z

Configuration of both uWSGI (for local usage) and of the Docker container needs cleaning, but I can see /ping working.

Last part of libero/publisher#31

thewilkybarkid · 2018-08-20T08:28:02Z

Pipfile

@@ -9,6 +9,7 @@ pytest = "~=3.7.1"
 [packages]
 flask = "~=1.0.2"
 flask-sqlalchemy = "*"
+uwsgi = "*"


These unbounded constraints are a bad idea.

It is only the default, we should pin on at least 2.*

Who's default, Pipfile?

Pipenv.lock fixes the version. There are examples in the Pipenv documentation and the Pipfile project.
I think the recommendation is to only specify the versions we know we require (e.g. known minimum version). You can then still install dependencies as per the lock file for deterministic builds and use the Pipfile to upgrade dependencies. There may be some official documentation explaining that more.

Default of pipenv install $packagename; I have now specified 2.0.* which avoids surprises when upgrading dependencies

thewilkybarkid · 2018-08-20T08:29:12Z

Pipfile.lock

@@ -100,15 +107,15 @@
                "sha256:6e3836e39f4d36ae72840833db137f7b7d35105079aee6ec4a62d9f80d594dd1",
                "sha256:95eb8364a4708392bae89035f45341871286a333f749c3141c20573d2b3876e1"
            ],
-            "markers": "python_version != '3.1.*' and python_version >= '2.7' and python_version != '3.3.*' and python_version != '3.2.*' and python_version != '3.0.*'",
+            "markers": "python_version >= '2.7' and python_version != '3.1.*' and python_version != '3.2.*' and python_version != '3.3.*' and python_version != '3.0.*'",


Pipfile producing different results again?

I'm using https://github.com/libero/content-store/pull/13/files#diff-04c6e90faac2675aa89e2176d2eec7d8R35 so that it becomes consistent

thewilkybarkid · 2018-08-20T08:30:04Z

README.md

+docker-compose run --name my_install venv pipenv install uwsgi
+docker cp my_install:/Pipfile.lock Pipfile.lock
+docker cp my_install:/Pipfile.lock Pipfile.lock
+docker rm my_install


Should use a Docker Compose override instead.

pipenv cannot write to a mounted Pipfile.lock because it creates a new file in place of the old one. Could probably try mounting the whole folder 🤔

thewilkybarkid · 2018-08-20T08:31:36Z

content_store/api/wsgi.py

@@ -0,0 +1,3 @@
+from content_store.api.api import create_app


The app shouldn't be in the api namespace, let alone twice!

General structure (until there is logic to organize) still unclear, but a few (hopefully one) stable top-level package(s) is needed, the rest can be moved around

giorgiosironi · 2018-08-20T10:14:46Z

Run into pypa/pipenv#2760 but not harmful.

thewilkybarkid · 2018-08-21T08:54:43Z

Dockerfile.venv

@@ -1,9 +1,14 @@
 ARG python_base_image_tag
 FROM python:${python_base_image_tag}
+
+# uwsgi build process dependencies
+RUN apk update && apk add gcc libc-dev linux-headers


--no-cache

thewilkybarkid · 2018-08-21T08:54:55Z

Dockerfile.venv

@@ -1,9 +1,14 @@
 ARG python_base_image_tag
 FROM python:${python_base_image_tag}
+
+# uwsgi build process dependencies
+RUN apk update && apk add gcc libc-dev linux-headers
 RUN pip install --no-cache-dir --only-binary --upgrade pipenv


Should merge the two RUNs.

Can do, although there's not particular trigger that would re-execute these outside of the package names

(can even merge 3)

thewilkybarkid · 2018-08-21T08:56:00Z

docker-compose.yml

-        environment:
-            - FLASK_APP=content_store/api/api.py
-        command: flask run --host=0.0.0.0
+        # TODO: check what to use for uwsgi


Was this resolved?

It works better with the current configuration, as the default SIGTERM is not handled. This can usually be tweaked with the uwsgi configuration but, not being in the container image, I want to see a real one first.

(by default it will handle SIGINT and SIGQUIT)

giorgiosironi · 2018-08-21T16:02:01Z

All changes incorporated.

giorgiosironi · 2018-08-21T16:10:02Z

Another Pipfile.lock conflict...

giorgiosironi added 5 commits August 17, 2018 17:42

Document process for Python package installation

5ea9034

Install uwsgi

12a754c

Rename main container to app

4d97f9e

Exposing a callable to uWSGI

6b27ab8

Run uwsgi in place of flask

c2ad6a7

giorgiosironi requested a review from jhroot August 17, 2018 17:37

thewilkybarkid reviewed Aug 20, 2018

View reviewed changes

giorgiosironi added 2 commits August 20, 2018 09:55

Pin packages minor versions

68e363d

Move Pipfile* into /pipfiles and install in a pre-created venv

53ef3f2

Simplify installation of new Python package

439b7d2

giorgiosironi changed the title ~~[wip] Proof of concept of uWSGI usage~~ Proof of concept of uWSGI usage Aug 20, 2018

giorgiosironi changed the title ~~Proof of concept of uWSGI usage~~ [wip] Proof of concept of uWSGI usage Aug 20, 2018

giorgiosironi added 3 commits August 21, 2018 09:25

Remove nobody user suggestion as it prevents port 80 use

b8cd2a5

Merge remote-tracking branch 'origin/master' into wsgi

926276b

Move down detail about DevelopmentConfig

e62e5a8

giorgiosironi changed the title ~~[wip] Proof of concept of uWSGI usage~~ Proof of concept of uWSGI usage Aug 21, 2018

giorgiosironi changed the title ~~Proof of concept of uWSGI usage~~ Run with uWSGI usage Aug 21, 2018

thewilkybarkid reviewed Aug 21, 2018

View reviewed changes

giorgiosironi added 4 commits August 21, 2018 11:21

Use --no-cache for apk

51bb963

Join RUN statements

ca2738e

Adopt SIGINT as the development stopping mechanism for uwsgi

6c56a2f

Merge remote-tracking branch 'origin/master' into wsgi

a53a011

giorgiosironi and others added 2 commits August 21, 2018 17:15

Merge remote-tracking branch 'origin/master' into wsgi

e7ec57b

Merge branch 'master' into wsgi

9403338

thewilkybarkid approved these changes Aug 22, 2018

View reviewed changes

giorgiosironi merged commit c607f73 into master Aug 22, 2018

giorgiosironi deleted the wsgi branch August 22, 2018 08:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run with uWSGI usage #13

Run with uWSGI usage #13

giorgiosironi commented Aug 17, 2018 •

edited

Loading

thewilkybarkid Aug 20, 2018

giorgiosironi Aug 20, 2018

thewilkybarkid Aug 20, 2018

de-code Aug 20, 2018

giorgiosironi Aug 20, 2018

thewilkybarkid Aug 20, 2018

giorgiosironi Aug 20, 2018

thewilkybarkid Aug 20, 2018

giorgiosironi Aug 20, 2018

thewilkybarkid Aug 20, 2018

giorgiosironi Aug 20, 2018 •

edited

Loading

giorgiosironi commented Aug 20, 2018

thewilkybarkid Aug 21, 2018

thewilkybarkid Aug 21, 2018

giorgiosironi Aug 21, 2018

giorgiosironi Aug 21, 2018

thewilkybarkid Aug 21, 2018

giorgiosironi Aug 21, 2018

giorgiosironi Aug 21, 2018

giorgiosironi commented Aug 21, 2018

giorgiosironi commented Aug 21, 2018

Run with uWSGI usage #13

Run with uWSGI usage #13

Conversation

giorgiosironi commented Aug 17, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

giorgiosironi Aug 20, 2018 • edited Loading

Choose a reason for hiding this comment

giorgiosironi commented Aug 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

giorgiosironi commented Aug 21, 2018

giorgiosironi commented Aug 21, 2018

giorgiosironi commented Aug 17, 2018 •

edited

Loading

giorgiosironi Aug 20, 2018 •

edited

Loading