Skip to content
This repository has been archived by the owner on Sep 25, 2018. It is now read-only.

Lint imports #18

Closed
wants to merge 1 commit into from
Closed

Lint imports #18

wants to merge 1 commit into from

Conversation

thewilkybarkid
Copy link
Contributor

No description provided.

@@ -1,2 +1,4 @@
[flake8]
application-import-names = content_store
import-order-style = google
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roughly standard library, dependencies, current codebase?

"isort": {
"hashes": [
"sha256:1153601da39a25b14ddc54955dbbacbb6b2d19135386699e2ad58517953b34af",
"sha256:b9c40e9750f3d77e6e4d441d8b0266cf555e7cdabdcff33c4fd06366ca761ef8",
"sha256:ec9ef8f4a9bc6f71eec99e1806bfa2de401650d996c59330782b89a5555c1497"
],
"markers": "python_version != '3.0.*' and python_version != '3.1.*' and python_version != '3.2.*' and python_version >= '2.7' and python_version != '3.3.*'",
"markers": "python_version != '3.1.*' and python_version != '3.0.*' and python_version >= '2.7' and python_version != '3.2.*' and python_version != '3.3.*'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this locked using the README guide and it changed anyway?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used the container... 😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values are identical, it's only the order in this case that changed: pypa/pipenv#2760

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, hadn’t seen pipenv lock. Need to look at what that does given the lock file is already updated.

Copy link
Member

@giorgiosironi giorgiosironi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are benign, I'd look into the lock unnecessary changes if they are really unnecessary

@thewilkybarkid
Copy link
Contributor Author

Closing this rather than resolving the conflict, as the repo's about to be archived.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants