Start using PSR-2 #2
Conversation
| public function bar ( $baz ,&$qux, bool$quux, ? string $quuz =null , string...$corge ): | ||
| void | ||
| { | ||
| } |
There was a problem hiding this comment.
Can't include an abstract example yet, waiting for squizlabs/PHP_CodeSniffer#2148 to be merged/released.
| <properties> | ||
| <property name="spacesCountBeforeColon" value="1"/> | ||
| </properties> | ||
| </rule> | ||
| <rule ref="Squiz.Classes.ClassFileName"/> |
There was a problem hiding this comment.
No example for traits yet, waiting for squizlabs/PHP_CodeSniffer#2140 to the merged/released.
|
|
||
| namespace Vendor; | ||
|
|
||
| use Foo, Bar; |
There was a problem hiding this comment.
No function and const examples yet, waiting for squizlabs/PHP_CodeSniffer#2143 to be released.
There was a problem hiding this comment.
How does this deal with PHP 7s grouped statements
use some\namespace\{ClassA, ClassB, ClassC as C};There was a problem hiding this comment.
Was going to forbid them later, but looks like it already transforms them. Will add a test.
There was a problem hiding this comment.
ah nice it does it for the functions and consts too 👍
|
(Quick reviews would be useful, but will merge later this week otherwise.) |
| yield $file->getRelativePathname() => [ | ||
| $parts['filename'] ?? 'test.php', | ||
| "{$file->getRelativePathname()}/{$parts['filename']}", |
There was a problem hiding this comment.
There's some caching inside Slevomat Coding Standard so we need to make sure these are all considered unique.
| @@ -127,7 +144,7 @@ private function createFile(string $filename, string $content) : File | |||
| } | |||
|
|
|||
| $file = new DummyFile( | |||
| "phpcs_input_file:${filename}\n{$content}", | |||
| "phpcs_input_file:before/${filename}\n{$content}", | |||
There was a problem hiding this comment.
See #2 (comment).
| ---CONTENTS--- | ||
| <?php | ||
|
|
||
| $foo = '890123456789001234567890012345678900123456789001234567890012345678900123456789001234567890012345678900123456789'; |
There was a problem hiding this comment.
Is there a fixed out there for splitting this across more than one line?
There was a problem hiding this comment.
Not aware of one, probably quite a difficult task!
No description provided.