Skip to content
This repository was archived by the owner on Nov 21, 2019. It is now read-only.

Prefer single-quoted strings #31

Merged
merged 3 commits into from
Nov 15, 2018
Merged

Prefer single-quoted strings #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50393bb
Prefer single-quoted strings
thewilkybarkid Nov 5, 2018
6e84a5e
Update quotes
thewilkybarkid Nov 6, 2018
0e15348
Merge branch 'master' into string-quotes
thewilkybarkid Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Libero/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@
</rule>
<rule ref="Squiz.Classes.ClassFileName"/>
<rule ref="Squiz.PHP.InnerFunctions"/>
<rule ref="Squiz.Strings.DoubleQuoteUsage">
<exclude name="Squiz.Strings.DoubleQuoteUsage.ContainsVar"/>
Copy link
Contributor Author

@thewilkybarkid thewilkybarkid Nov 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with feedback. I find them simpler to read/write, but it's limited what you can do and behaviour is odd sometimes (https://stackoverflow.com/a/43437427).

</rule>
<rule ref="Squiz.WhiteSpace.CastSpacing"/>
<rule ref="Squiz.WhiteSpace.ObjectOperatorSpacing">
<properties>
Expand Down
2 changes: 1 addition & 1 deletion tests/RulesetTests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public function cases() : iterable
if (empty($parts['contents'])) {
throw new LogicException("Couldn't find contents in {$file->getRelativePathname()}");
} elseif (empty(select_keys($parts, $keys))) {
throw new LogicException("Expected one of ".implode(', ', $keys)." in {$file->getRelativePathname()}");
throw new LogicException('Expected one of '.implode(', ', $keys)." in {$file->getRelativePathname()}");
}

try {
Expand Down
23 changes: 23 additions & 0 deletions tests/cases/php/string-quotes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---DESCRIPTION---
Double quotes must not be used for strings unless required
---CONTENTS---
<?php

declare(strict_types=1);

$foo = "bar";
$baz = "qux {$quux}";
$quuz = "'";
$corge = "\n";

---FIXED---
<?php

declare(strict_types=1);

$foo = 'bar';
$baz = "qux {$quux}";
$quuz = "'";
$corge = "\n";

---