Remove meaningless comments and normalise formatting #35
Conversation
| ---MESSAGES--- | ||
| 6:1 Squiz.Commenting.BlockComment.NoEmptyLineBefore | ||
| 16:1 Squiz.Commenting.BlockComment.CloserSameLine | ||
| 16:1 Squiz.Commenting.BlockComment.NoEmptyLineAfter |
There was a problem hiding this comment.
Shame these aren't fixed.
tests/cases/whitespace/comments-line
Outdated
| // Foo | ||
| // Bar | ||
| echo 'baz'; // qux | ||
| // quux |
There was a problem hiding this comment.
Would rather the extra spaces before these two were removed.
There was a problem hiding this comment.
Looks like Doesn't do indentation.Squiz.Commenting.InlineComment should fix at least the latter.
There was a problem hiding this comment.
Generic.WhiteSpace.ScopeIndent can be configured to fix the latter.
There was a problem hiding this comment.
Setting the exact value to true fixes it, but creates problems elsewhere. For example, indentation of array elements in removed. There is Generic.Arrays.ArrayIndent which can be used, but they seem to conflict.
There was a problem hiding this comment.
Looks problematic to try and resolve, let's not hold up the rest.
| <element value="@api"/> | ||
| <element value="@author"/> | ||
| <element value="@category"/> | ||
| <element value="@copyright"/> |
There was a problem hiding this comment.
https://github.com/doctrine/coding-standard/blob/0247a0d440e196d93611bd0f3c561ee12bd82789/lib/Doctrine/ruleset.xml#L161 also has @created, but can't see references to that anywhere else.
thewilkybarkid
changed the title
2 participants
Not yet complete.