This repository was archived by the owner on Nov 21, 2019. It is now read-only.
Normalise parentheses #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/cases/php/parentheses-useless
Outdated
| switch ($quuz) { | ||
| case true: | ||
| case false: | ||
| return $corge / (100 + $grault); |
There was a problem hiding this comment.
I'm curious about the effect on (60 * 60 * 24) * $days (or similar) which has unnecessary parentheses but can make the calculation more clear
There was a problem hiding this comment.
Better test case:
$ php -r "var_dump(true or false and false);"
bool(true)
$ php -r "var_dump(true or (false and false));"
bool(true)
$ php -r "var_dump((true or false) and false);"
bool(false)
The second case has unnecessary parentheses but is counterintuitive without them.
There was a problem hiding this comment.
All those examples are unaffected.
((60 * 60 * 24 * $days) is also unaffected when it is useless though.)
|
The build contains an unrelated error, but the concerns about parentheses have been addressed. |
|
Build problem is addressed in #37. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.