Allow multi-line method chaining

[thewilkybarkid]

I can't see sniffs available anywhere that support multi-line method chaining (refs libero/schemas#6 (comment)).

This is an imperfect attempt to support it, without having to write dedicated sniffs.

[thewilkybarkid]

To avoid the namespace being Libero\CodingStandard\Libero. (Is there a way to have PHP_CodeSniffer work without having the ruleset's parent directory being the name? It's already defined in the ruleset itself...)

[thewilkybarkid]

Hmm, think we'll have to revert this. The sniff name ends up being CodingStandard. WhiteSpace.ObjectStaticOperatorSpacing rather than the expected Libero. WhiteSpace.ObjectStaticOperatorSpacing.

[giorgiosironi]

What's the decision here in the end? Happy either way

[thewilkybarkid]

Would rather these became multiline.

[giorgiosironi]

It is reasonable for me to allow an existing single-line statement to remain single-line, while if you want to go multi-line then you would have to follow a standard.

[thewilkybarkid]

Would rather not keep the newline.

[thewilkybarkid]

Unsure about whether the semi-colon should go on the next line. Produces nicer diffs, but looks ugly.

[stephenwf]

Ah so this is enforced, even if you manually put it on the next line.

[stephenwf]

Diff might look something like this:

$foo
    ->bar(
        $arg1,
        $arg2
+    )
+    ->baz(
+        $arg1,
+        $arg2
     );

[giorgiosironi]

I thought semicolon-on-next-line was a Symfony standard by now

[giorgiosironi]

I'd favor it not because of the diffs but because keeps lines independent (for fluent interfaces, which is the use case for chained calls):

• add a new call
• remove a call
• change the order of calls
• swap two calls
  become operations that only involve full lines

[thewilkybarkid]

@giorgiosironi Happy to merge? I'd like to update this to put the semi-colon on the next line, but will need a custom sniff I believe so will do it later.

[giorgiosironi]

As per my latest comments, all reasonable