This repository was archived by the owner on Nov 22, 2019. It is now read-only.
package libero schemas as python package #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What should be the |
Contributor
Author
Can you set it to both php and python reviewers? |
Contributor
Author
|
Tests currently failing due to libero/publisher#159 |
python/Dockerfile
Outdated
|
|
||
| WORKDIR /src/app | ||
|
|
||
| COPY . . |
There was a problem hiding this comment.
unrelated to grammars, but this is an anti-pattern as any change to any file requires pip install to run again, invalidating the layer cache
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caveats:
In order to allow the repo to be installed using pip via git/github, to keep the
libero_schemasnamespace, I've placed the directory containing the python source codelibero_schemasoutside of thepythondirectory where all other python code resides exceptsetup.pyandMANIFEST.infor the same reason.