Forward declare open_temp_exec_file #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's defined in closures.c and used in tramp.c. Also declare it as an hidden symbol, as it should be.
serge-sans-paille
force-pushed
the
missing-forward-declaration
branch
from
aead3c5 to
cbfb9b4
Compare
|
Fixes #760. Thank you! |
|
Thanks for the quick merge \o |
This was referenced Mar 30, 2023
dixyes
added a commit
to dixyes/lwmbs
that referenced
this pull request
Jun 18, 2023
|
We’re also running into this. Would be great to see a new library release containing this. 🙏 |
7 tasks
|
Please make a new release containing this fix. The current version of libffi has not been buildable with the current version of clang for nearly a year now, and you can see from the linked issues (both here and in #760) that this has affected many people. |
|
I will prepare a new release very soon. Thanks for the feedback. |
YSaxon
added a commit
to YSaxon/conan-center-index
that referenced
this pull request
Mar 19, 2024
BlackHole1
added a commit
to BlackHole1/ovm-core
that referenced
this pull request
May 11, 2024
When using the new version of GCC, it is unable to compile libffi. Ref: libffi/libffi#764 Thanks @serge-sans-paille for your patch :) Signed-off-by: Kevin Cui <bh@bugs.cc>
6 tasks
BlackHole1
added a commit
to oomol-lab/ovm-core
that referenced
this pull request
May 11, 2024
When using the new version of GCC, it is unable to compile libffi. Ref: libffi/libffi#764 Thanks @serge-sans-paille for your patch :) Signed-off-by: Kevin Cui <bh@bugs.cc>
tdf-gerrit
pushed a commit
to LibreOffice/core
that referenced
this pull request
Jul 16, 2024
* external/libffi/implicit-function-declaration.patch was obsolete after libffi/libffi#764 * Backport external/python3/0001-bpo-45898-Remove-duplicate-symbols-from-_ctypes-cfie.patch.1 from upstream to fix build errors on Windows. Change-Id: I6d7cd70dd29ea0ce4b22738637afa0e7eb76a93f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167337 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's defined in closures.c and used in tramp.c.
Also declare it as an hidden symbol, as it should be.