Improve FreeBSD support: #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozhuk-im
commented
May 9, 2020
rozhuk-im
commented
- include posix_openpt() usage patch
- add workaround for readdir() issue: Seeking in directory stream has no effect #211
- fix few warnings
Nikratio
reviewed
May 10, 2020
Nikratio
reviewed
May 10, 2020
Nikratio
reviewed
May 10, 2020
Nikratio
requested changes
May 10, 2020
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jun 5, 2020
- include posix_openpt() usage patch - add workaround for readdir() issue: #211 - fix few warnings - Add DOCS option - remove gettext dep Upstream patches: libfuse/sshfs#212 libfuse/sshfs#211 PR: 246325 Submitted by: rozhuk.im@gmail.com git-svn-id: svn+ssh://svn.freebsd.org/ports/head@538024 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jun 5, 2020
- include posix_openpt() usage patch - add workaround for readdir() issue: #211 - fix few warnings - Add DOCS option - remove gettext dep Upstream patches: libfuse/sshfs#212 libfuse/sshfs#211 PR: 246325 Submitted by: rozhuk.im@gmail.com
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Jun 5, 2020
- include posix_openpt() usage patch - add workaround for readdir() issue: #211 - fix few warnings - Add DOCS option - remove gettext dep Upstream patches: libfuse/sshfs#212 libfuse/sshfs#211 PR: 246325 Submitted by: rozhuk.im@gmail.com git-svn-id: svn+ssh://svn.freebsd.org/ports/head@538024 35697150-7ecd-e111-bb59-0022644237b5
|
Are you still interested in working on this? If not, I'll close the pull request in a few days. |
|
FreeBSD already take this into ports tree :) How do you suggest to rework this? |
|
I'm happy with most of the patch, but I don't understand the need for the readdir workaround. I'd much rather see it removed from the patch and discussed separately. |
|
Are you still interested in working on this? If not, I'll close this pull request for now. |
rozhuk-im
force-pushed
the
fbsd_fixes
branch
2 times, most recently
from
df68941 to
d2623b2
Compare
- include posix_openpt() usage patch - add workaround for readdir() issue: libfuse#211, libfuse#278 - fix few warnings
|
Does pam_mount exist on FreeBSD? Otherwise I think it is better to disable the password_stdin flag. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.