Add release workflow #209
Add release workflow #209
Conversation
| - name: Publish package | ||
| run: ./gradlew packageWinX64 packageLinuxX64 | ||
| - name: Release | ||
| uses: softprops/action-gh-release@v2 |
There was a problem hiding this comment.
I really don't know the first thing about GH Actions, but since this is on the libgdx organization now, I think I need to get the OK from @Tom-Ski or someone else in the org before doing anything with third-party actions. I don't even know if softprops is third-party...
.github/workflows/release.yml
Outdated
| - name: Setup Gradle | ||
| uses: gradle/actions/setup-gradle@v3 | ||
| - name: Publish package | ||
| run: ./gradlew packageWinX64 packageLinuxX64 |
There was a problem hiding this comment.
This doesn't need to run ./gradlew clean first, right? Because each run is in a container?
|
Testing on my fork to see how the action works: |
|
This looks really clean and nice! I do want to hear from someone else in the organization about our policies for GH Actions and whether this looks clean and nice to them, so I guess I'll ping @MobiDevelop and @Tom-Ski . |
|
While I don't have a whole lot of experience with GH Actions... I don't personally have any problem with third party actions, presuming they are actively maintained and don't have any known security issues. I don't currently have time to review the action in question, but probably best that someone does so we have a good gauge on it. |
|
I can testify on the actively maintained (the repository is updated quite often), as I've been using this action for quite some years on personal projects. Cannot vouch for the security part as that's not my area of expertise |
This PR adds a release workflow which is triggered upon pushing a new tag